The future of a tax break that has saved New York City developers billions of dollars has emerged as the thorniest issue in the state capital, twisting political alliances, alarming the city’s real-estate interests and serving as another...